Deeploy/DeeployTypes.py (2)

327-349: Bug: visited initialized as set(self.name) (set of characters), not a set of names.

This can degrade traversal correctness and performance for alias cycles. Initialize with the buffer name itself.

-        visited = set(self.name)
+        visited = {self.name}
-        while len(queue) > 0:
-            next = queue.pop()
-            buffNext = ctxt.lookup(next)
+        while len(queue) > 0:
+            next_name = queue.pop()
+            buffNext = ctxt.lookup(next_name)
             assert isinstance(buffNext, VariableBuffer)
             live |= buffNext._live
-            visited.add(next)
-            queue |= buffNext.aliases - visited
+            visited.add(next_name)
+            queue |= (buffNext.aliases - visited)

---

946-979: Make hoistConstant robust to np.ndarray-valued constants.

The method currently assumes a gs.Constant object, but line 2462 in DeeployTypes.py passes x.attrs['value'] directly, which may be a numpy array. This will crash when accessing .outputs and .name. Wrap numpy arrays into gs.Constant before processing, and update the signature to accept Union[gs.Constant, np.ndarray].

-    def hoistConstant(self,
-                      constant: gs.Constant,
-                      name: Optional[str] = None,
-                      _type: Optional[Type[Pointer]] = None) -> str:
+    def hoistConstant(self,
+                      constant: Union[gs.Constant, np.ndarray],
+                      name: Optional[str] = None,
+                      _type: Optional[Type[Pointer]] = None) -> str:
         """Register a ConstantBuffer extracted directly from a graphsurgeon Constant

         Parameters
         ----------
-        constant : gs.Constant
-            graphsurgeon.Node containing a single constant output
+        constant : Union[gs.Constant, np.ndarray]
+            graphsurgeon.Node containing a single constant output, or a numpy array
         name : str
             Name of the ConstantBuffer to be registered
         _type : Optional[Type[Pointer]]
             Optional type assignment of the registered ConstantBuffer

         Returns
         -------
         str
             Returns the name of the newly registed ConstantBuffer

         """
+        # Normalize to a gs.Constant (GraphSurgeon tensor)
+        if isinstance(constant, np.ndarray):
+            constant = gs.Constant(name if name is not None else "CONST", constant)
         assert len(constant.outputs) <= 1, f"Constant {constant.name} has more than one output"

         name = name if name is not None else constant.name

Deeploy/DeeployTypes.py (1)

327-349: Critical bug: incorrect initialization of visited set.

Line 341 incorrectly initializes visited as set(self.name). Since self.name is a string, this creates a set of individual characters rather than a set containing the string. This breaks the BFS traversal because:

• Line 347 adds buffer names (strings) to visited
• Line 348's set subtraction buffNext.aliases - visited won't work correctly
• Could cause infinite loops if there are cycles in the alias graph

Apply this diff:

-        visited = set(self.name)
+        visited = {self.name}